This repository was archived by the owner on Feb 23, 2021. It is now read-only.
Add more packages to cache #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pranavkm
suggested changes
Apr 24, 2017
| @@ -71,7 +71,7 @@ Microsoft.AspNetCore.Mvc.Localization,ship,include | |||
| Microsoft.AspNetCore.Mvc.Razor,ship,include | |||
| Microsoft.AspNetCore.Mvc.Razor.Extensions,ship,include | |||
| Microsoft.AspNetCore.Mvc.RazorPages,ship,include | |||
| Microsoft.AspNetCore.Mvc.Razor.ViewCompilation,ship,exclude | |||
| Microsoft.AspNetCore.Mvc.Razor.ViewCompilation,ship,include | |||
There was a problem hiding this comment.
This doesn't have any runtime components. Are we just using this as a way to get the package in the .All package now?
There was a problem hiding this comment.
There was a problem hiding this comment.
Marking as ship,include for now since it should be in the metapackage. This functionally does not affect anything right now but we should revisit what these fields mean. ship vs no-ship, include in metapackage vs not, include in cache vs not.
| @@ -119,24 +119,24 @@ Microsoft.Data.Sqlite,ship,include | |||
| Microsoft.Data.Sqlite.Core,ship,include | |||
| Microsoft.DotNet.Watcher.Tools,ship,exclude | |||
| Microsoft.EntityFrameworkCore,ship,include | |||
| Microsoft.EntityFrameworkCore.Design,ship,exclude | |||
| Microsoft.EntityFrameworkCore.Design,ship,include | |||
|
Verified these changes in the MetaPackage repo so merging these to keep packages.csv up to date. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to keep this in sync with MetaPackages's list of runtime package store. Updating due to aspnet/MetaPackages#43