Skip to content
This repository was archived by the owner on Nov 6, 2018. It is now read-only.

Rename events on PhysicalFileWatcher can throw - Crashing VS. #187

@NTaylorMullen

Description

@NTaylorMullen

In some of Visual Studios test cases when they open a file => new web app 50+ times they eventually encounter crashes here. Essentially Directory.EnumerateFileSystemEntries explodes due to a node_modules file being renamed then locked.

This is a problem for Visual Studio because it ends up crashing it; however, it is infrequent. This can be mitigated by changing Mvc/Razor to only monitor the Views folder, it currently gets file watcher change events for all of the node_modules folder additions/renames during restore. This can also be fixed across the board by catching around this logic.

Not sure of the severity of this issue.

/cc @Eilon @ToddGrun @pranavkm

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions