Urls not read from appsettings.json

[b-stime]

See #1298 for my quick attempt at a fix via the GitHub web interface.

[b-stime]

@muratg
@Tratcher

What are you exactly trying to fix? Is there a bug filed for the issue you're targeting here?

This code doesn't compile. _startup.Configure is a method, not an IConfiguration instance. I'm closing this and we can discuss it issue over at #1299.

I guess this may've already been discussed at some length* but it continues to burn new users (e.g., me)...

The issue is that you don't appear to be able to configure the webhost port via a config file or command line out of the box when you create a project via:

$ dotnet new razor

The WebHostBuilder already parses appsettings.json and the command line args and hydrates the Startup object IConfigure so my patch attempt seemed like an easy way to reduce astonishment.

* https://stackoverflow.com/a/45854704/93345
// #1148
// aspnet/KestrelHttpServer#1851

[Tratcher]

[Rambling investigation]

The command line issue was fixed here: aspnet/MetaPackages#221. The workaround is here: aspnet/MetaPackages#221 (comment)

A similar workaround works for appsettings.json as well.

The new Kestrel config file support also reads from appsettings.json.
aspnet/KestrelHttpServer#1290 (comment)

So the remaining gap is reading Urls from appsettings.json. Right now it's read from the wrong config layer. Hosting builds an initial configuration and services so it has enough information to build the rest of the app, like the Environment. But it also reads Urls from this config.

Hosting/src/Microsoft.AspNetCore.Hosting/Internal/WebHost.cs

Line 290 in cd3f58b

var urls = _config[WebHostDefaults.ServerUrlsKey] ?? _config[DeprecatedServerUrlsKey];

The other config is built seperately and added to the app services:

Hosting/src/Microsoft.AspNetCore.Hosting/WebHostBuilder.cs

Lines 246 to 256 in cd3f58b

	var builder = new ConfigurationBuilder()
	.SetBasePath(_hostingEnvironment.ContentRootPath)
	.AddConfiguration(_config);
	foreach (var configureAppConfiguration in _configureAppConfigurationBuilderDelegates)
	{
	configureAppConfiguration(_context, builder);
	}
	var configuration = builder.Build();
	services.AddSingleton<IConfiguration>(configuration);

Option A to fix this would be to resolve the IConfiguration from the app services like how it resolves the server except as optional.

Hosting/src/Microsoft.AspNetCore.Hosting/Internal/WebHost.cs

Line 284 in cd3f58b

Server = _applicationServices.GetRequiredService<IServer>();

That config could be used as another entry in the fallback search, likely after the existing items to minimize the compat risk.

Hosting/src/Microsoft.AspNetCore.Hosting/Internal/WebHost.cs

Line 290 in cd3f58b

var urls = _config[WebHostDefaults.ServerUrlsKey] ?? _config[DeprecatedServerUrlsKey];

Or option B we change WebHostBuilder to pass in the app's config into WebHost from _context.Configuration rather than the host config, but this would affect more components and be a riskier change.

Hosting/src/Microsoft.AspNetCore.Hosting/WebHostBuilder.cs

Line 257 in cd3f58b

_context.Configuration = configuration;

Hosting/src/Microsoft.AspNetCore.Hosting/WebHostBuilder.cs

Lines 186 to 190 in cd3f58b

	var host = new WebHost(
	applicationServices,
	hostingServiceProvider,
	_options,
	_config,

Recommendation: Option A

[muratg]

We'll reconsider this in 2.2

cc @glennc

[muratg]

Recommendation is to set the URLs with server specific settings. We won't be making other changes here.

[sharmilasubbiah]

Did this " Urls not read from appsettings.json or command line to Urls not read from appsettings.json" sorted ?? I am trying to make this work with no luck . Just wondering if you can help me please , thank you

[Tratcher]

No, we opted not to take this change. 2.1 offers a different way to configure urls for kestrel from the config file. See the new kestrel docs. https://docs.microsoft.com/en-us/aspnet/core/fundamentals/servers/kestrel?view=aspnetcore-2.1&tabs=aspnetcore2x#how-to-use-kestrel-in-aspnet-core-apps