Skip to content
This repository was archived by the owner on Dec 19, 2018. It is now read-only.

Use HostingNullLogScope when no logging #609

Closed
wants to merge 1 commit into from
Closed

Use HostingNullLogScope when no logging #609

wants to merge 1 commit into from

Conversation

benaadams
Copy link
Contributor

Drops the HostingLogScope from this
After-QueueUserWorkItemCallback

Resolves #367

/cc @davidfowl

@davidfowl
Copy link
Member

Checking IsEnabled for the Hosting logger isn't enough. You need to be able to check if there are any logging providers at all and there's no way to do that.

/cc @lodejard @rynowak

@benaadams
Copy link
Contributor Author

DI or lambda \ Func<object, object> scope?

e.g.

return logger.BeginScopeImpl((state) => new HostingLogScope((HttpContext)state), httpContext);

@benaadams benaadams mentioned this pull request Feb 22, 2016
Closed
sajayantony
sajayantony reviewed Feb 22, 2016
View reviewed changes
src/Microsoft.AspNetCore.Hosting/Internal/HostingLoggerExtensions.cs
}
}

public void Dispose()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Elide?

@benaadams
Copy link
Contributor Author

Need to see how this goes aspnet/Logging#366

@davidfowl
Copy link
Member

Closing until the logging issue is resolved.

@davidfowl davidfowl closed this Mar 2, 2016
@davidfowl davidfowl mentioned this pull request Feb 15, 2017
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benaadams @davidfowl @sajayantony @dnfclas