This repository was archived by the owner on Mar 19, 2019. It is now read-only.
Add flag to disable synchronous IO #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
campersau
reviewed
Jun 27, 2017
| @@ -111,6 +112,10 @@ private void ValidateReadBuffer(byte[] buffer, int offset, int size) | |||
|
|
|||
| public override unsafe int Read([In, Out] byte[] buffer, int offset, int size) | |||
| { | |||
| if (!RequestContext.AllowSynchronousIO) | |||
| { | |||
| throw new InvalidOperationException("Syncronous IO APIs are disabled, see AllowSynchronousIO."); | |||
| @@ -91,10 +91,16 @@ public override long Position | |||
| // Send headers | |||
| public override void Flush() | |||
| { | |||
| if (!RequestContext.AllowSynchronousIO) | |||
| { | |||
| throw new InvalidOperationException("Syncronous IO APIs are disabled, see AllowSynchronousIO."); | |||
| @@ -449,9 +455,15 @@ private HttpApi.HTTP_FLAGS ComputeLeftToWrite(long writeCount, bool endOfRequest | |||
|
|
|||
| public override void Write(byte[] buffer, int offset, int count) | |||
| { | |||
| if (!RequestContext.AllowSynchronousIO) | |||
| { | |||
| throw new InvalidOperationException("Syncronous IO APIs are disabled, see AllowSynchronousIO."); | |||
Tratcher
force-pushed
the
tratcher/nosync
branch
from
27a9e61 to
bbc7620
Compare
Tratcher
force-pushed
the
tratcher/nosync
branch
2 times, most recently
from
0c1f285 to
b2eaf80
Compare
|
Updated to enable sync by default. |
halter73
reviewed
Jul 5, 2017
| if (!RequestContext.AllowSynchronousIO) | ||
| { | ||
| throw new InvalidOperationException("Synchronous IO APIs are disabled, see AllowSynchronousIO."); | ||
| } |
halter73
reviewed
Jul 5, 2017
| } | ||
| } | ||
|
|
||
| [ConditionalFact] |
There was a problem hiding this comment.
Out of curiosity, where is the condition?
There was a problem hiding this comment.
halter73
reviewed
Jul 5, 2017
| public async Task RequestBody_ReadSync_Success() | ||
| { | ||
| string address; | ||
| using (var server = Utilities.CreateHttpServer(out address)) | ||
| { | ||
| Task<string> responseTask = SendRequestAsync(address, "Hello World"); | ||
|
|
||
| server.Options.AllowSynchronousIO = true; |
There was a problem hiding this comment.
Are these lines in your tests still necessary now the true is the default?
There was a problem hiding this comment.
Not at the moment, but they will be when we switch the default and since I had already fixed them there was no point in reverting it.
halter73
approved these changes
Jul 5, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#366 Read, Write, and Flush now throw by default. There's some debate on Flush because it breaks StreamWriter.Dispose().