Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Update to React 15 #255

Closed
geirsagberg opened this issue Aug 12, 2016 · 4 comments
Closed

Update to React 15 #255

geirsagberg opened this issue Aug 12, 2016 · 4 comments

Comments

@geirsagberg
Copy link
Contributor

aspnet-webpack-react currently uses React 0.14, which leaves data-reactid-attributes all over the output. Updating to v 15 will fix this, and some other issues (https://facebook.github.io/react/blog/2016/04/07/react-v15.html).
@geirsagberg geirsagberg mentioned this issue Aug 12, 2016
Closed
@SteveSandersonMS
Copy link
Member

Sounds good! Would you be able to submit a pull request?

@geirsagberg
Copy link
Contributor Author

Yup, see #256.

@SteveSandersonMS
Copy link
Member

Thanks - closing in favour of #256

@geirsagberg
Copy link
Contributor Author

A quick note; seems the react-id-attributes are still there in React 15 when calling renderToString, as they are needed to connect the client code. Still, updating to React 15 shouldn't have any adverse effects.

@snyk-bot snyk-bot mentioned this issue Nov 10, 2021
Open
@harunpehlivan harunpehlivan mentioned this issue Nov 5, 2022
Open
@snyk-bot snyk-bot mentioned this issue Dec 26, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geirsagberg @SteveSandersonMS