Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

outdated readme.md #366

Closed
lucamorelli opened this issue Oct 7, 2016 · 4 comments
Closed

outdated readme.md #366

lucamorelli opened this issue Oct 7, 2016 · 4 comments

Comments

@lucamorelli
Copy link

if I run the angular 2 generator of aspnetcore spa yo generator and I open the readme.md I find

Welcome to ASP.NET 5

@SteveSandersonMS
Copy link
Member

Well spotted!

As it happens, this was already fixed (53889c0). We haven't yet published updates to the templates, but when we do, you'll be able to get them by running npm install -g generator-aspnetcore-spa again, so it will apply to any future projects you create.

@MarkPieszak
Copy link
Contributor

@SteveSandersonMS By any chance, could we update the ReadMe's a little further as well, to point out the things each one has (the framework, maybe how prerendering works, helpful links, etc)?

I can start typing up some basic stuff if you'd like as well. Just an idea!

@SteveSandersonMS
Copy link
Member

There are already docs (e.g., https://github.com/aspnet/JavaScriptServices/blob/dev/README.md and https://github.com/aspnet/JavaScriptServices/blob/dev/src/Microsoft.AspNetCore.SpaServices/README.md).

We could link to those, but let's avoid duplicating the content. Also, since the README.md content is currently shared with the other ASP.NET templates (the non-SPA ones), we should avoid diverging from their content and format much, because then it would be an extra thing to maintain.

@MarkPieszak
Copy link
Contributor

Sounds good to me! We link to the template as a Universal starter, I'll just make sure we have some notes there explaining what it is & how to use it. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants