Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Updating ts-loader to 0.9.* breaks webpack hot module replacement #388

Closed
d0pare opened this issue Oct 17, 2016 · 4 comments
Closed

Updating ts-loader to 0.9.* breaks webpack hot module replacement #388

d0pare opened this issue Oct 17, 2016 · 4 comments

Comments

@d0pare
Copy link
Contributor

d0pare commented Oct 17, 2016

I am not sure this is related to this repository, just opened for conversation.
When I updated ts-loader to 0.9.* it broke hot module replacement. Now all modules are rebuilding on every change.

With 0.8.2:

[HMR] connected
client.js:128 [HMR] bundle rebuilding
client.js:132 [HMR] bundle rebuilt in 224ms
process-update.js:27 [HMR] Checking for updates on the server...
process-update.js:100 [HMR] Updated modules:
process-update.js:102 [HMR]  - ./ClientApp/app/components/counter/counter.component.html
process-update.js:102 [HMR]  - ./ClientApp/app/components/counter/counter.component.ts
process-update.js:102 [HMR]  - ./ClientApp/app/app.module.ts
process-update.js:102 [HMR]  - ./ClientApp/boot-client.ts
process-update.js:107 [HMR] App is up to date.

With 0.9.3:

[HMR] connected
client.js:128 [HMR] bundle rebuilding
client.js:132 [HMR] bundle rebuilt in 5264ms
process-update.js:27 [HMR] Checking for updates on the server...
process-update.js:100[HMR] Updated modules:
process-update.js:102[HMR]  - ./ClientApp/boot-client.ts
process-update.js:102[HMR]  - ./ClientApp/app/app.module.ts
process-update.js:102[HMR]  - ./ClientApp/app/components/app/app.component.ts
process-update.js:102[HMR]  - ./ClientApp/app/components/navmenu/navmenu.component.ts
process-update.js:102[HMR]  - ./ClientApp/app/components/home/home.component.ts
process-update.js:102[HMR]  - ./ClientApp/app/components/fetchdata/fetchdata.component.ts
process-update.js:102[HMR]  - ./ClientApp/app/components/counter/counter.component.ts
process-update.js:102[HMR]  - ./ClientApp/app/components/counter/counter.component.html
process-update.js:107[HMR] App is up to date.
@d0pare d0pare changed the title Updating ts-loader to Updating ts-loader to 0.9.3 breaks webpack hot module replacement Oct 17, 2016
@d0pare d0pare changed the title Updating ts-loader to 0.9.3 breaks webpack hot module replacement Updating ts-loader to 0.9.* breaks webpack hot module replacement Oct 17, 2016
@SteveSandersonMS
Copy link
Member

Thanks for letting us know.

But like you mention, wouldn't you regard that as a bug in ts-loader? If they are only incrementing the version from 0.8.x to 0.9.x then they shouldn't be introducing breaking changes. Would you be willing to report this to ts-loader?

@d0pare
Copy link
Contributor Author

d0pare commented Oct 17, 2016

@SteveSandersonMS sure, I will report this to them.

@SteveSandersonMS
Copy link
Member

Thanks. I'll close this as an external issue.

@d0pare
Copy link
Contributor Author

d0pare commented Oct 17, 2016

OK
Created an issue on ts-loader repo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants