Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

bug: Angular 2 not working with InputOutputStream #94

Closed
wants to merge 2 commits into from

Conversation

laskoviymishka
Copy link
Contributor

Closes #93
We need to ensure that output recieved data is real boot function response, and not just regular console.log from node process.
This is pretty dumb, but it will fix basic behaivior which described in #93.
If anyone have some ideas how it could be improved, any feedback would be GREAT!

@laskoviymishka
Copy link
Contributor Author

laskoviymishka commented Jun 1, 2016

update to latest master. Ping @SteveSandersonMS

@SteveSandersonMS
Copy link
Member

Thanks for submitting this. Looking for a { character may resolve the issue in the specific case of #93, but as you point out, leaves open the underlying issue which is that the InputOutputStream transport will trip up if it sees unexpected data on the stream (and that unexpected data might include a {).

The InputOutputStream transport was never meant for real use - it was just to show that other types of transport were possible.

I've just pushed the new Socket transport, which is a robust and more generalised stream-based transport. Socket will soon become the new default (replacing Http) once I've got a bit more feedback about it, because it's faster and has more capabilities than Http.

Now Socket is in place, I'm going to remove InputOutputStream altogether, as it no longer serves any purpose. If anyone has any objections please let me know.

If you don't mind, then, I'll close this as it will no longer be applicable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular 2 in debug mode not working with InputOutputStream
3 participants