Skip to content
This repository was archived by the owner on Dec 18, 2018. It is now read-only.

FrameRequestStream/HttpRequestStream is not compatible with CryptoStream #2341

Closed
kekekeks opened this issue Feb 21, 2018 · 1 comment
Closed

FrameRequestStream/HttpRequestStream is not compatible with CryptoStream #2341

kekekeks opened this issue Feb 21, 2018 · 1 comment
Assignees
@davidfowl
Labels
3 - Done bug
Milestone
2.1.0-preview2

Comments

@kekekeks
Copy link
Contributor 

System.NotSupportedException: Specified method is not supported.
   at Microsoft.AspNetCore.Server.Kestrel.Core.Internal.Http.FrameRequestStream.Flush()
   at System.Security.Cryptography.CryptoStream.FlushFinalBlock()
   at System.Security.Cryptography.CryptoStream.Dispose(Boolean disposing)

CryptoStream.Dispose is calling Flush on the underlying stream even if said stream is read only - https://github.com/dotnet/corefx/issues/27326

Apparently this is intended behavior of CryptoStream and Flush shouldn't ever throw exceptions: dotnet/corefx#27327 (review)
kekekeks added a commit to kekekeks/KestrelHttpServer that referenced this issue Feb 21, 2018
@kekekeks
Don't throw in HttpRequestStream.Flush
abe35a2 
Because read-only streams apparently can have Flush semantics and this behavior is expected by some of built-in stream wrappers (e. g. CryptoStream)

dotnet/corefx#27327 (review)
aspnet#2341
@kekekeks kekekeks mentioned this issue Feb 21, 2018
Merged
kekekeks added a commit to kekekeks/KestrelHttpServer that referenced this issue Feb 23, 2018
@kekekeks
Don't throw in HttpRequestStream.Flush
adaf0ce 
Because read-only streams apparently can have Flush semantics and this behavior is expected by some of built-in stream wrappers (e. g. CryptoStream)

dotnet/corefx#27327 (review)
aspnet#2341
kekekeks added a commit to kekekeks/KestrelHttpServer that referenced this issue Feb 23, 2018
@kekekeks
Don't throw in HttpRequestStream.Flush
0f3c71c 
Because read-only streams apparently can have Flush semantics and this behavior is expected by some of built-in stream wrappers (e. g. CryptoStream)

dotnet/corefx#27327 (review)
aspnet#2341
kekekeks added a commit to kekekeks/KestrelHttpServer that referenced this issue Feb 23, 2018
@kekekeks
Don't throw in HttpRequestStream.Flush
02a3a1a 
Because read-only streams apparently can have Flush semantics and this behavior is expected by some of built-in stream wrappers (e. g. CryptoStream)

dotnet/corefx#27327 (review)
aspnet#2341
davidfowl pushed a commit that referenced this issue Feb 23, 2018
@kekekeks @davidfowl
Don't throw in HttpRequestStream.Flush (#2342)
39951e8 
Because read-only streams apparently can have Flush semantics and this behavior is expected by some of built-in stream wrappers (e. g. CryptoStream)

dotnet/corefx#27327 (review)
#2341
@davidfowl
Copy link
Member

Fixed by #2342

@davidfowl davidfowl added this to the 2.1.0-preview2 milestone Feb 24, 2018
@davidfowl davidfowl self-assigned this Feb 24, 2018
@drauch drauch mentioned this issue Jan 22, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidfowl davidfowl

Labels
3 - Done bug
Projects
None yet
Milestone
2.1.0-preview2
Development

No branches or pull requests
2 participants
@davidfowl @kekekeks