Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Fix DebugLogger to log exception details #388

Closed
kevinchalet opened this issue Mar 13, 2016 · 6 comments
Closed

Fix DebugLogger to log exception details #388

kevinchalet opened this issue Mar 13, 2016 · 6 comments
Assignees
Milestone

Comments

@kevinchalet
Copy link

@BrennanConroy recently fixed EventLogLogger to log exceptions, but DebugLogger didn't get the same love: 6b07c6a#diff-9bbe2418382dbe1fba6ad79cb1f4a081R104.

That would be great if the debug logger could log exception details: https://github.com/aspnet/Logging/blob/dev/src/Microsoft.Extensions.Logging.Debug/DebugLogger.cs#L75.

/cc @davidfowl

@muratg muratg added this to the 1.0.0-rc2 milestone Mar 16, 2016
@muratg muratg added the bug label Mar 16, 2016
@muratg
Copy link

muratg commented Mar 16, 2016

@BrennanConroy Could you review the remaining implementations and do the same thing across the board?

@ORuban
Copy link
Contributor

ORuban commented Mar 17, 2016

Hi, I have created a PR #391 using the same way as for EventLogLogger.

And actually I have a question about formatting:

  • in TraceSourceLogger the only one Environment.NewLine is added before exception // link to code
  • in EventLogLogger (and so in this PR for DebugLogger) there are two Environment.NewLine(s) before exception // link to code

So maybe add/remove one Environment.NewLine ?

@BrennanConroy
Copy link
Member

@loudej You said 2 newlines for EventLogLogger, how about for DebugLogger?

@BrennanConroy
Copy link
Member

@lodejard
Whoops, used your other one, see above

@BrennanConroy
Copy link
Member

9f4dee9

@kevinchalet
Copy link
Author

Thanks! 👏 👏

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants