Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Configuration and Filtering changes #565

Closed
@BrennanConroy

Description

@BrennanConroy
  • Add void AddProvider(string providerName, ILoggerProvider provider) to LoggerFactory
    LoggerFactory(IConfiguration config) will be the way to add configuration to our factory
  • Support named providers
    • Check typeof(type).FullName
    • Name passed into AddProvider wins always
  • Example format:
{
  "Logging": { // default values unless otherwise specified
    "LogLevel": {
        "System": "Trace"
    },
    "Console": {
        "LogLevel": {
          "Microsoft.Extensions": "Warning"
        }
    },
    "CustomProvider": { // e.g. factory.AddProvider("CustomProvider", new MyCustomProvider())
      "LogLevel": {
        "System": "Information"
      }
    }
  }
}

- [ ] Remove ability to call AddProvider whenever you want, only allowed during startup

  • Obsolete AddConsole(this ILoggerFactory factory, IConfiguration configuration)

Figure this out:

  • Obsolete void AddProvider(ILoggerProvider provider) on ILoggerFactory

Stretch goal:

  • Add AddFilter(string providerName, Func<string, LogLevel, bool> filter) to LoggerFactory
    • AddFilter is additive

Activity

added this to the 2.0.0 milestone on Mar 8, 2017
cwe1ss

cwe1ss commented on Mar 22, 2017

@cwe1ss
Contributor

Will you react to changes in the underlying configuration system?

My desired scenario: Configuration is loaded from an external system like Consul. I want to be able to change the logging configuration in-flight without having to restart the application.

BrennanConroy

BrennanConroy commented on Mar 22, 2017

@BrennanConroy
MemberAuthor

Yeah, we will handle config changes at runtime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

    Development

    No branches or pull requests

      Participants

      @muratg@cwe1ss@BrennanConroy

      Issue actions

        Configuration and Filtering changes · Issue #565 · aspnet/Logging