Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

Move NullLoggerFactory and NullLoggerOfT to Microsoft.Extensions.Logging.Abstractions #566

Closed
ajaybhargavb opened this issue Mar 8, 2017 · 2 comments
Closed

Move NullLoggerFactory and NullLoggerOfT to Microsoft.Extensions.Logging.Abstractions #566

ajaybhargavb opened this issue Mar 8, 2017 · 2 comments
Assignees
@ajaybhargavb
Labels
3 - Done bug
Milestone
2.0.0-preview1

Comments

@ajaybhargavb
Copy link
Contributor

From aspnet/DataProtection#203 (comment)

We currently have NullLogger and NullLoggerProvider in Logging.Abstractions but NullLoggerFactory is in Logging.Testing. It should be moved to Logging.Abstractions so it can be used in other places like the one referenced above.

@Eilon
@ajaybhargavb ajaybhargavb mentioned this issue Mar 8, 2017
Merged
@Eilon
Copy link
Member

Eilon commented Mar 8, 2017

@muratg @davidfowl @DamianEdwards - any objections? This seems like good cleanup because we have a mess of NullLoggerXyz's scattered around.

@davidfowl
Copy link
Member

👍

@muratg muratg added this to the 2.0.0 milestone Mar 8, 2017
@ajaybhargavb ajaybhargavb mentioned this issue Mar 9, 2017
Merged
@ajaybhargavb ajaybhargavb mentioned this issue Mar 11, 2017
Merged
@ajaybhargavb ajaybhargavb changed the title Move NullLoggerFactory to Microsoft.Extensions.Logging.Abstractions Move NullLoggerFactory and NullLoggerOfT to Microsoft.Extensions.Logging.Abstractions Mar 11, 2017
@ajaybhargavb ajaybhargavb mentioned this issue Mar 14, 2017
Merged
@rynowak rynowak mentioned this issue Apr 11, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajaybhargavb ajaybhargavb

Labels
3 - Done bug
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
4 participants
@davidfowl @Eilon @ajaybhargavb @muratg