NullLoggerFactory and friends are in the wrong namespace

[rynowak]

All of these types are in the Microsoft.Extensions.Logging.Abstractions - whereas the types that they implement are in Microsoft.Extensions.Logging.

See: #566 - I don't see any discussion of the namespace in this issue or the PR which leads me to believe it's not intentional.

[muratg]

cc @ajaybhargavb @Eilon @davidfowl

[Eilon]

I think we did see this while @ajaybhargavb was doing all the NullLoggerXyz cleanup, but perhaps it was too big of a breaking change? I don't recall exactly...

[ajaybhargavb]

I don't remember what exactly but some of these types were used in repos that only needed to depend on Microsoft.Extensions.Logging.Abstractions.

[davidfowl]

We should fix it.

[rynowak]

I don't remember what exactly but some of these types were used in repos that only needed to depend on Microsoft.Extensions.Logging.Abstractions.

The issue I'm raising here is that the namespace is wrong.

[Eilon]

@ajaybhargavb can you compare what was shipped in 1.1.x to what we have in 2.0-dev?

[muratg]

Assigned to @ajaybhargavb for investigation.

[ajaybhargavb]

From the comparison, the namespace NullLoggerFactory is in is consistent with NullLogger and NullLoggerProvider from rel/1.1.2.

Do we want to change all of those to Microsoft.Extensions.Logging?

[muratg]

@ajaybhargavb will this fit in preview1? If so please bring this back to 2.0.0-preview1 milestone. Thanks.

[ajaybhargavb]

I'll see how many repos will need the update. But first, are we okay with this breaking change?

[Eilon]

Talked with @muratg and @ajaybhargavb and given that this would be an annoying breaking for almost no value, so closing it.