Skip to content
This repository was archived by the owner on Dec 13, 2018. It is now read-only.

LoggerFactoryExtension.CreateLogger<T> now returns an ILogger<T> #318

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.

using System;
using Microsoft.Extensions.Internal;

namespace Microsoft.Extensions.Logging
{
Expand All @@ -16,14 +15,14 @@ public static class LoggerFactoryExtensions
/// </summary>
/// <typeparam name="T">The type.</typeparam>
/// <param name="factory">The factory.</param>
public static ILogger CreateLogger<T>(this ILoggerFactory factory)
public static ILogger<T> CreateLogger<T>(this ILoggerFactory factory)
{
if (factory == null)
{
throw new ArgumentNullException(nameof(factory));
}

return factory.CreateLogger(TypeNameHelper.GetTypeDisplayName(typeof(T), fullName: true));
return new Logger<T>(factory);
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information.

using System;
using Microsoft.Extensions.Internal;

namespace Microsoft.Extensions.Logging
{
Expand All @@ -13,14 +14,19 @@ namespace Microsoft.Extensions.Logging
public class Logger<T> : ILogger<T>
{
private readonly ILogger _logger;

/// <summary>
/// Creates a new <see cref="Logger{T}"/>.
/// </summary>
/// <param name="factory">The factory.</param>
public Logger(ILoggerFactory factory)
{
_logger = factory.CreateLogger<T>();
if (factory == null)
{
throw new ArgumentNullException(nameof(factory));
}

_logger = factory.CreateLogger(TypeNameHelper.GetTypeDisplayName(typeof(T), fullName: true));
}

IDisposable ILogger.BeginScopeImpl(object state)
Expand Down