This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Fix unix Console colors #430
Merged
+39
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Agreed, which is why I got a screen shot. Should we do something about it? |
|
@BrennanConroy What are the other possible colors we can put instead of red? Also, did you try both types of reds? |
|
We decided to change fail to red background, black text |
|
@BrennanConroy update screenshot? Also doesn't that make |
|
Possible colors are in this color table https://en.wikipedia.org/wiki/ANSI_escape_code#Colors |
|
|
|
|
1 similar comment
|
|
BrennanConroy
force-pushed
the
brecon/fix_unix_colors
branch
from
1ca9564 to
960e571
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#417
@davidfowl @kichalla @muratg
