This repository was archived by the owner on Nov 21, 2018. It is now read-only.
Use file globbing to resolve manifests #143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
approved these changes
Jun 6, 2017
muratg
approved these changes
Jun 6, 2017
JunTaoLuo
commented
Jun 6, 2017
| @@ -15,12 +11,19 @@ Error if PublishWithAspNetCoreTargetManifest is set to true for standalone app | |||
| --> | |||
| <Target | |||
| Name="PublishWithAspNetCoreTargetManifest" | |||
| BeforeTargets="Publish" | |||
| DependsOnTargets="PrepareForPublish" | |||
| AfterTargets="PrepareForPublish" | |||
There was a problem hiding this comment.
🆙📅 we need to run this target earlier than we have been to ensure TargetManifestFiles is set before all dotnet/sdk targets that rely on it.
|
Closed in 35ec069 |
This was referenced Jun 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up to #127.
Now that we have an updated CLI with the changes we needed, we can at least use file globbing to resolve the manifest names. This can go into preview2 but is also not necessary.