This repository was archived by the owner on Nov 21, 2018. It is now read-only.
Use new SelfContained property #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
force-pushed
the
johluo/self-contained
branch
2 times, most recently
from
73d5863 to
c715758
Compare
|
Tested this with SelfContained app (RID specific, aka standalone), RID specific portable and portable apps. Ready to merge. |
pranavkm
approved these changes
Jun 29, 2017
JunTaoLuo
force-pushed
the
johluo/self-contained
branch
from
c715758 to
64ed5bb
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #175.
We will inspect this property instead of RuntimeIdentifier/RuntimeIdentifiers to determine whether the TargetManifestFiles should be updated. This new property is set in the sdk: https://github.com/dotnet/sdk/blob/43090565482d9a10481ff2298fb168fc819fa430/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.RuntimeIdentifierInference.targets#L107-L110
Still needs to be tested before being reviewed.