Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Use new SelfContained property #177

Merged
merged 1 commit into from
Jun 29, 2017
Merged

Use new SelfContained property #177

merged 1 commit into from
Jun 29, 2017

Conversation

JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented Jun 24, 2017

Addresses #175.

We will inspect this property instead of RuntimeIdentifier/RuntimeIdentifiers to determine whether the TargetManifestFiles should be updated. This new property is set in the sdk: https://github.com/dotnet/sdk/blob/43090565482d9a10481ff2298fb168fc819fa430/src/Tasks/Microsoft.NET.Build.Tasks/build/Microsoft.NET.RuntimeIdentifierInference.targets#L107-L110

Still needs to be tested before being reviewed.

@JunTaoLuo JunTaoLuo force-pushed the johluo/self-contained branch 2 times, most recently from 73d5863 to c715758 Compare June 29, 2017 02:14
@JunTaoLuo
Copy link
Contributor Author

Tested this with SelfContained app (RID specific, aka standalone), RID specific portable and portable apps. Ready to merge.

@JunTaoLuo JunTaoLuo requested a review from pranavkm June 29, 2017 19:11
@JunTaoLuo JunTaoLuo force-pushed the johluo/self-contained branch from c715758 to 64ed5bb Compare June 29, 2017 23:50
@JunTaoLuo JunTaoLuo merged commit 64ed5bb into dev Jun 29, 2017
@JunTaoLuo JunTaoLuo deleted the johluo/self-contained branch June 29, 2017 23:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants