Add Microsoft.AspNetCore.All metapackage and build package cache #18
Conversation
|
@JunTaoLuo, |
build.ps1
Outdated
| @@ -33,7 +33,7 @@ cd $PSScriptRoot | |||
| $repoFolder = $PSScriptRoot | |||
| $env:REPO_FOLDER = $repoFolder | |||
|
|
|||
| $koreBuildZip="https://github.com/aspnet/KoreBuild/archive/dev.zip" | |||
| $koreBuildZip="https://github.com/aspnet/KoreBuild/archive/stable-cache.zip" | |||
There was a problem hiding this comment.
Can you file individual follow up items for each of the hacks we have here?
There was a problem hiding this comment.
I think this is going to cause issues in universe builds. The CLI and shared runtime are locked by the outer msbuild process, so this will fail. What does it take to not do this?
There was a problem hiding this comment.
no longer needed, will remove.
build/dependencies.props
Outdated
| @@ -1,6 +1,9 @@ | |||
| <Project> | |||
| <PropertyGroup> | |||
| <AspNetCoreVersion>2.0.0-*</AspNetCoreVersion> | |||
| <AspNetCore01Version>0.1.0-*</AspNetCore01Version> | |||
There was a problem hiding this comment.
This is pretty meaningless. Can you use package names instead?
There was a problem hiding this comment.
Rather annoying that 03 is used for Diagnostics.Elm, Proxy and Buffering but sure I'll name them.
|
|
||
| <ItemGroup> | ||
| <!-- set PrivateAssets=None to ensure that all assets, including Build and Analyzer, are included in the nuspec --> | ||
| <PackageReference Include="Microsoft.AspNetCore.Antiforgery" Version="$(AspNetCoreVersion)" PrivateAssets="None" /> |
There was a problem hiding this comment.
Follow up to use packages.csv to generate this file.
| <PackageReference Include="Microsoft.AspNetCore.Cryptography.KeyDerivation" Version="$(AspNetCoreVersion)" PrivateAssets="None" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.DataProtection" Version="$(AspNetCoreVersion)" PrivateAssets="None" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.DataProtection.Abstractions" Version="$(AspNetCoreVersion)" PrivateAssets="None" /> | ||
| <!--<PackageReference Include="Microsoft.AspNetCore.DataProtection.AzureStorage" Version="$(AspNetCoreVersion)" PrivateAssets="None" />--> |
| <ItemGroup> | ||
| <!-- set PrivateAssets=None to ensure that all assets, including Build and Analyzer, are included in the nuspec --> | ||
| <PackageReference Include="Microsoft.AspNetCore.Antiforgery" Version="$(AspNetCoreVersion)" PrivateAssets="None" /> | ||
| <!--<PackageReference Include="Microsoft.AspNetCore.ApplicationInsightsLightup" Version="$(AspNetCoreVersion)" PrivateAssets="None" />--> |
There was a problem hiding this comment.
Actually these shouldn't be removed. A few of the packages need to be in the cache but not the metapackage and the others need to be included but are blocked based on other issues. I'll add some notes linking to the individual issues.
|
|
||
| <PropertyGroup> | ||
| <IncludeBuildOutput>false</IncludeBuildOutput> | ||
| <TargetFramework>netstandard2.0</TargetFramework> |
There was a problem hiding this comment.
Can this be netstandard1.6? Does it have to be a 2.0 package?
build/repo.targets
Outdated
|
|
||
| <RemoveDir Directories="$(OutputPath)" /> | ||
| <RemoveDir Directories="$(WorkingDirectory)" /> | ||
| <Exec Command="dotnet cache --entries $(MetaPackageFile) --framework netcoreapp2.0 --runtime win7-x64 --output $(OutputPath) --framework-version 2.0.0-beta-001776-00 --working-dir $(WorkingDirectory)" /> |
There was a problem hiding this comment.
Follow up to fix
- The hardcoded rid
- The hardcoded fx-version
There was a problem hiding this comment.
I'm actually going to fix the hardcoded rid right now to be determined by the platform type. Will file issue with the hardcoded fx-version
There was a problem hiding this comment.
Star works for --framework-version apparently
NuGet.config
Outdated
| <!-- Workaround for missing package on our feed --> | ||
| <add key="DotNetCore" value="https://dotnet.myget.org/F/dotnet-core/api/v3/index.json" /> | ||
| <!-- Additional feeds for dotnet cache --> | ||
| <add key="Roslyn" value="https://dotnet.myget.org/F/roslyn/api/v3/index.json" /> |
There was a problem hiding this comment.
Won't need this yet, since it's pulled in via M.N.A for apps but we will need it once we move to 2.0.
NuGet.config
Outdated
| @@ -3,6 +3,10 @@ | |||
| <packageSources> | |||
| <add key="AspNetCore" value="https://dotnet.myget.org/F/aspnetcore-ci-dev/api/v3/index.json" /> | |||
| <add key="AspNetCoreTools" value="https://dotnet.myget.org/F/aspnetcore-tools/api/v3/index.json" /> | |||
| <!-- Workaround for missing package on our feed --> | |||
| <add key="DotNetCore" value="https://dotnet.myget.org/F/dotnet-core/api/v3/index.json" /> | |||
There was a problem hiding this comment.
The System.Numerics.Vector that we spoke about yesterday. https://github.com/aspnet/CoreCLR/pull/175. Did this get fixed?
WIP