Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Validate scopes in Development environment in CreateDefaultBuilder #61

Merged
merged 1 commit into from
Apr 27, 2017
Merged

Validate scopes in Development environment in CreateDefaultBuilder #61

merged 1 commit into from
Apr 27, 2017

Conversation

pakrym
Copy link
Contributor

@pakrym pakrym commented Apr 26, 2017

Fixes: #58
/cc @DamianEdwards

@pakrym pakrym requested review from davidfowl and JunTaoLuo April 26, 2017 15:58
@pakrym pakrym added this to the 2.0.0-preview1 milestone Apr 26, 2017
@pakrym pakrym mentioned this pull request Apr 26, 2017
Closed
@pakrym pakrym changed the base branch from dev to rel/2.0.0-preview1 April 26, 2017 16:02
@pakrym pakrym force-pushed the pakrym/validate-scopes branch from a4d6291 to 9ca0b73 Compare April 26, 2017 16:05
@pakrym pakrym removed this from the 2.0.0-preview1 milestone Apr 26, 2017
davidfowl
davidfowl approved these changes Apr 26, 2017
View reviewed changes
Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pakrym pakrym requested a review from muratg April 26, 2017 21:54
muratg
muratg approved these changes Apr 26, 2017
View reviewed changes
Copy link

@muratg muratg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JunTaoLuo could you take a look as well?

JunTaoLuo
JunTaoLuo approved these changes Apr 26, 2017
View reviewed changes
Copy link
Contributor

@JunTaoLuo JunTaoLuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good, would prefer adding a test though

@pakrym pakrym mentioned this pull request Apr 27, 2017
Closed
@pakrym
Copy link
Contributor Author

pakrym commented Apr 27, 2017

@JunTaoLuo filed #72 will do for preview2

@pakrym pakrym merged commit d4f39bf into rel/2.0.0-preview1 Apr 27, 2017
@JunTaoLuo JunTaoLuo deleted the pakrym/validate-scopes branch June 7, 2017 18:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@muratg muratg muratg approved these changes

@JunTaoLuo JunTaoLuo JunTaoLuo approved these changes

Assignees
No one assigned
Labels
cla-already-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pakrym @davidfowl @muratg @JunTaoLuo @dnfclas