Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Add more packages #71

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Add more packages #71

merged 1 commit into from
Apr 28, 2017

Conversation

JunTaoLuo
Copy link
Contributor

@JunTaoLuo JunTaoLuo commented Apr 27, 2017

Addressing a few packages left behind in #21

Packages to add:

  • Microsoft.EntityFrameworCore.Tools,ship,exclude
  • Microsoft.VisualStudio.Web.CodeGeneration,ship,exclude
  • Microsoft.VisualStudio.Web.CodeGeneration.Contracts,ship,exclude
  • Microsoft.VisualStudio.Web.CodeGeneration.Core,ship,exclude
  • Microsoft.VisualStudio.Web.CodeGeneration.Design,ship,exclude
  • Microsoft.VisualStudio.Web.CodeGeneration.EntityFrameworkCore,ship,exclude
  • Microsoft.VisualStudio.Web.CodeGeneration.Templating,ship,exclude
  • Microsoft.VisualStudio.Web.CodeGeneration.Utils,ship,exclude
  • Microsoft.VisualStudio.Web.CodeGenerators.Mvc,ship,exclude

The Scaffolding packages cannot be added right now due to dotnet/roslyn#16040

Copy link

@muratg muratg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JunTaoLuo This package is the "runtime" part of the EF tool, right? (Not the actual tool...) In that case, approved.

@JunTaoLuo
Copy link
Contributor Author

Scaffolding packages will be added to the .All metapackage only and will not be put into the runtime store. They are build time dependencies and are marked as PrivateAssets="All" so they are not included in the publish output.

@JunTaoLuo JunTaoLuo requested review from Eilon and pakrym and removed request for pakrym April 28, 2017 21:15
@JunTaoLuo JunTaoLuo force-pushed the johluo/add-packages branch from 456dfb2 to 18acd97 Compare April 28, 2017 21:54
@JunTaoLuo JunTaoLuo merged commit 18acd97 into rel/2.0.0-preview1 Apr 28, 2017
@JunTaoLuo JunTaoLuo deleted the johluo/add-packages branch April 28, 2017 21:55
@JunTaoLuo JunTaoLuo mentioned this pull request Apr 28, 2017
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants