This repository was archived by the owner on Dec 13, 2018. It is now read-only.
Always call prior handlers in challenge #982
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @HaoK, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
Tratcher
approved these changes
Sep 21, 2016
| @@ -323,7 +328,7 @@ protected virtual Task<bool> HandleForbiddenAsync(ChallengeContext context) | |||
| /// changing the 401 result to 302 of a login page or external sign-in location.) | |||
| /// </summary> | |||
| /// <param name="context"></param> | |||
| /// <returns>True if no other handlers should be called</returns> | |||
| /// <returns>The returned boolean is ignored.</returns> | |||
There was a problem hiding this comment.
"The returned boolean is no longer used."
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tratcher
FYI I have a 'bad feeling about this' change, no tests failed either as a result :/... I added one to verify the new behavior
Fixes #930