This repository was archived by the owner on Dec 18, 2018. It is now read-only.
Upgrade SignalR.Core to netcoreapp3.0 #3315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates samples, tests, and projects to netcoreapp3.0. Notably, the SignalR client remains netstandard2.0
| @@ -23,8 +21,8 @@ | |||
|
|
|||
| <!-- These references are used when running on the Benchmarks Server --> | |||
| <ItemGroup Condition="'$(BenchmarksTargetFramework)' != ''"> | |||
| <PackageReference Include="Microsoft.AspNetCore.All" Version="$(MicrosoftAspNetCoreAllPackageVersion)" /> | |||
There was a problem hiding this comment.
Hmm, don't change this stuff unless you know 100% that the benchmarks infrastructure works with it
There was a problem hiding this comment.
We killed Microsoft.AspNetCore.All. Benchmarks infrastructure will have to update.
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>netcoreapp2.2;net461</TargetFrameworks> | |||
| <TargetFrameworks>netcoreapp3.0;net461</TargetFrameworks> | |||
There was a problem hiding this comment.
The client still supports it because the client is netstandard.
|
Tests passing now :) |
muratg
reviewed
Nov 17, 2018
BrennanConroy
approved these changes
Nov 17, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates samples, tests, and projects to netcoreapp3.0.
Notably, the SignalR client remains netstandard2.0
Part of dotnet/aspnetcore#3754