This repository was archived by the owner on Dec 20, 2018. It is now read-only.
[2.1]: Add package version to Microsoft.AspNetCore.App in project templates #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natemcmaster
added
the
servicing-consider
JunTaoLuo
approved these changes
Jul 3, 2018
| $@"<Project> | ||
| <Import Project=""{templatesTestsTargetsFilePath}"" /> | ||
| </Project>"; | ||
| const string directoryBuildTargetsContent = "<Project></Project>"; |
There was a problem hiding this comment.
nit:
would be sufficient here.
natemcmaster
added
servicing-approved
|
Yes, this was approved in shiproom this morning. We will be making a bunch of tweaks to docs, warnings, tooling, etc. over the next few weeks to follow up on this change. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of dotnet/aspnetcore#3292
We're reversing course on the implicit package version feature. This adds a package version for Microsoft.AspNetCore.App to the
dotnet newand VS templates.cc @DamianEdwards @JunTaoLuo