This repository was archived by the owner on Oct 18, 2018. It is now read-only.
fix build by adding OutputType exe to test project #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
continuing to work around dotnet/sdk#909
analogrelay
commented
May 25, 2017
| @@ -0,0 +1,17 @@ | |||
| #if NET461 | |||
There was a problem hiding this comment.
Wasn't able to quickly track down how we fixed this before. In netcoreapp2.0 the Test SDK brings a dummy Program.Main, but in net461 we need one to make the compiler happy (because of <OutputType>exe</>), thus the #if
JunTaoLuo
approved these changes
May 25, 2017
| @@ -0,0 +1,17 @@ | |||
| #if NET461 | |||
There was a problem hiding this comment.
Now that we have a green build, I'll just add that as I merge.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
continuing to work around dotnet/sdk#909
Merging after AppVeyor and Travis runs to unblock build.