Skip to content

Possibility to use Condition in hasValues of row assertions #110

Open
@soezen

Description

@soezen

I would like to include condition objects when I call the hasValue method of a row assertion

softAssertions.assertThat(changes)
                .changeOnTableWithPks(tableName, primaryKeyValue)
                .isCreation()
                .rowAtEndPoint()
                .hasValues(1, 'Test', new HamcrestCondition<>(Matchers.greaterThan(2)));

Activity

linked a pull request that will close this issue on Oct 20, 2020
VanRoy

VanRoy commented on Nov 1, 2020

@VanRoy
Member

Hi @soezen , thanks for your report and your PR. It's a good idea. However, I think it would be better to implement this feature with different method name and implement some tests.
I can handle this, and I also plan to support Consumer in addition to Condition for many assertj-db methods.
I'll let you know quickly.

soezen

soezen commented on Nov 2, 2020

@soezen
ContributorAuthor
VanRoy

VanRoy commented on Feb 23, 2021

@VanRoy
Member

Hi @soezen , a first implementation of hasValuesSatisfying with Condition is pushed on main.
It wil be available soon in the next release.
Sorry for the delay.

added this to the 2.1.0 milestone on Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      Participants

      @VanRoy@soezen

      Issue actions

        Possibility to use Condition in hasValues of row assertions · Issue #110 · assertj/assertj-db