Skip to content

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Jun 12, 2025

An alternative to #14006

@Gankra Gankra added the internal A refactor or improvement that is not user-facing label Jun 12, 2025
@Gankra
Copy link
Contributor Author

Gankra commented Jun 12, 2025

cc @Xeonacid

@Xeonacid
Copy link
Contributor

Thanks a lot, Gankra!

Copy link
Member

@zanieb zanieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should avoid building these wheels, right? 🤔

@Gankra
Copy link
Contributor Author

Gankra commented Jun 12, 2025

We should avoid building these wheels, right? 🤔

I believe pypi is the bottleneck here and the wheels are technically usable if you hand them to like, uv or whatever to install them. Although since we don't upload them to the github release it's "know they're attached to the release workflow as random artifacts".

@konstin
Copy link
Member

konstin commented Jun 13, 2025

I have a prototype for a feature in maturin where it validates that only pypi-compatible wheels are build (maturin build --compatibility pypi), so in preparation for that, I'd be in favor of not building the wheels at all (the binaries can still go on the GitHub releases page).

@Gankra
Copy link
Contributor Author

Gankra commented Jun 13, 2025

Cool, i'll do a third crack at this

@Gankra
Copy link
Contributor Author

Gankra commented Jun 13, 2025

Notes:

  • The maturin action doesn't provide a way to build the binaries without the wheels
  • Dropping maturin would make this platform more annoying to build for
  • If we're building the wheels anyway we might as well yeet them into the artifacts for the CI run and use the wheel tests as smoke tests for the platform
  • We can omit compatibility: pypi for this one build if maturin adds that feature

@Gankra Gankra merged commit 49b4501 into main Jun 13, 2025
86 checks passed
@Gankra Gankra deleted the gankra/filterv64 branch June 13, 2025 13:57
zanieb added a commit that referenced this pull request Jul 23, 2025
zanieb added a commit that referenced this pull request Jul 23, 2025
zanieb added a commit that referenced this pull request Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal A refactor or improvement that is not user-facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants