Remove astroquery.utils.decorators
#2155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2155 +/- ##
==========================================
+ Coverage 66.24% 66.42% +0.18%
==========================================
Files 419 418 -1
Lines 28118 28026 -92
==========================================
- Hits 18626 18616 -10
+ Misses 9492 9410 -82
Continue to review full report at Codecov.
|
keflavich
approved these changes
Sep 23, 2021
bsipocz
requested changes
Sep 28, 2021
CHANGES.rst
Outdated
| The API for JPLspec's ``lookup_table.find`` function returns a dictionary | ||
| instead of values (for compatibility w/CDMS). [#2144] | ||
|
|
||
| - The functions ``astroquery.utils.decorators.deprecated()`` and |
There was a problem hiding this comment.
These never was part of the public API and was only internally used, so won't need a changelog.
https://astroquery.readthedocs.io/en/latest/utils.html?highlight=decorator
astroquery/utils/decorators.py
Outdated
| @@ -1,180 +1,20 @@ | |||
| from astropy.utils.decorators import deprecated as _deprecated | |||
| from astropy.utils.decorators import (deprecated_renamed_argument | |||
There was a problem hiding this comment.
no need for this, the module is entirely for internal usage, remove it altogether rather than deprecate.
The deleted file was no longer necessary because everything it defined can be safely imported directly from `astropy`, and there was only a single instance in the code where that was not being done already.
eerovaher
force-pushed
the
deprecate-decorators
branch
from
a6919e8 to
6845150
Compare
eerovaher
changed the title
astroquery.utils.decoratorsastroquery.utils.decorators
bsipocz
approved these changes
Sep 28, 2021
|
Thanks @eerovaher! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum required
astropyversion was updated in #1925, and that has made theastroquery.utils.decoratorsmodule obsolete.