Skip to content

Conversation

laukstein
Copy link
Contributor

Update to jQuery 1.7 with new event API .on() (do not forgot to add jQuery 1.7).
Update for jQuery Address foreign language URLs support on IE7 and IE6.

… jQuery 1.7.)

Update for jQuery Address foreign language URLs support on IE7 and IE6.
@asual
Copy link
Owner

asual commented Nov 4, 2011

Will this work if the plugin is used against older versions of jQuery?

@laukstein
Copy link
Contributor Author

No, it will work just with jQuery 1.7 and later versions.
Anyway sooner or later you will need to do this switch since jQuery rewrite their APIs; read more in http://blog.jquery.com/2011/11/03/jquery-1-7-released/

@asual asual closed this Mar 8, 2012
@tristans
Copy link

Would like to note that this pull request works across all browsers I've tested (IE8,9, FF15, Chrome 22).

laukstein - this pull request has helped me; thank you for it. I hope you might reopen the pull request so asual may re-think the decision to not merge it.

@asual
Copy link
Owner

asual commented Oct 14, 2012

I'm not sure what is the benefit of this refactoring but the change sounds better now since we have a newer jQuery 1.8.

@tristans
Copy link

Live is deprecated, and it makes sense to switch to the new event API that jQuery provides.

@oomlaut
Copy link

oomlaut commented Apr 23, 2013

What is the benefit (besides readability) of using .on instead of the .bind method?

@laukstein
Copy link
Contributor Author

@oomlaut .bind is a deprecated jQuery syntax.

@oomlaut
Copy link

oomlaut commented Apr 26, 2013

From the jQuery API .on may be preferred, however it is still a valid method, and has the benefit of being without much of the overhead of .on. Your documentation should note the incompatibilities and required revisions when working with versions prior to 1.7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants