Skip to content

fix: use correct start scripts for federations #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2023

Conversation

xoac
Copy link
Contributor

@xoac xoac commented Oct 13, 2023

  1. The start.sh scripts is now in correct folder
  2. cleanup functions try kill all PIDs (it didn't worked if one of process exited on it's own - for example when address was in use).

@urkle
Copy link

urkle commented Nov 9, 2023

@xoac we also need to update the README.md files to reference port 4000 instead of port 3000 as rover starts the router on port 4000 now.

@sunli829 sunli829 merged commit 35e3a15 into async-graphql:master Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants