Skip to content

useAsync T cannot be null #227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jbojcic1 opened this issue Nov 29, 2019 · 2 comments · Fixed by #229
Closed

useAsync T cannot be null #227

jbojcic1 opened this issue Nov 29, 2019 · 2 comments · Fixed by #229

Comments

@jbojcic1
Copy link

Currently useAsync is defined as useAsync<T extends {}> which means it cannot be null or undefined when using ts strict mode.

Example: https://codesandbox.io/s/react-typescript-9x4j1

This makes it impossible to use promise which returns SomeData | null
@ghengeveld
Copy link
Member

That's not right. @Khartir or @phryneas could you take a look?

@Khartir Khartir mentioned this issue Nov 30, 2019
Merged
1 task
@ghengeveld
Copy link
Member

This is fixed in v10.0.0 which was released today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix generix type declaration Khartir/react-async
2 participants
@ghengeveld @jbojcic1