Skip to content

Fix AsyncProps type #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2019
Merged

Fix AsyncProps type #19

merged 1 commit into from
Feb 2, 2019

Conversation

brabeji
Copy link
Contributor

@brabeji brabeji commented Feb 2, 2019

Hello! I think this is the way it meant to be. Thank you for the lib!

@codecov
Copy link

codecov bot commented Feb 2, 2019

Codecov Report

Merging #19 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #19   +/-   ##
=======================================
  Coverage   98.14%   98.14%           
=======================================
  Files           1        1           
  Lines          54       54           
  Branches       19       19           
=======================================
  Hits           53       53           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7271a7b...02c59c2. Read the comment docs.

@ghengeveld
Copy link
Member

Correct. Thanks for fixing!

@ghengeveld ghengeveld merged commit 1c79637 into async-library:master Feb 2, 2019
@ghengeveld
Copy link
Member

Published in v3.13.0.

@ghengeveld
Copy link
Member

@all-contributors please add @brabeji for code

@allcontributors
Copy link
Contributor

@ghengeveld

I've put up a pull request to add @brabeji! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants