Skip to content

[partial regression] Do not require a runtime in order to use net sockets #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dignifiedquire opened this issue Jun 18, 2020 · 3 comments · Fixed by #819
Closed

[partial regression] Do not require a runtime in order to use net sockets #818

dignifiedquire opened this issue Jun 18, 2020 · 3 comments · Fixed by #819
Labels
bug Something isn't working

Comments

@dignifiedquire
Copy link
Member

Some details and background libp2p/rust-libp2p#1612 (comment)

@dignifiedquire dignifiedquire added the bug Something isn't working label Jun 18, 2020
@dignifiedquire
Copy link
Member Author

As far as I can tell, the issue is that resolving socketaddrs can block at the moment, meaning we need some kind of blocking executor.

To fully resolve this getaddrinfo needs to be async.

https://github.com/c-ares/c-ares has likely some good details under the hood as well

@dignifiedquire
Copy link
Member Author

@dignifiedquire
Copy link
Member Author

After talking to @stjepang the dns resolution is not the actual issue, we need to ensure the reactor is actually running.

dignifiedquire added a commit that referenced this issue Jun 18, 2020
If this is not done, then reactor is not running, resulting in the sockets not actually connecting.

Closes #818
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant