move a-chat tutorial's code to this repo #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Sep 4, 2019
|
We can do that if we merge client and server into a single binary, i’ll Do that |
|
should be better now!
…On Wed, 4 Sep 2019 at 20:41, Stjepan Glavina ***@***.***> wrote:
***@***.**** commented on this pull request.
Can we delete .gitignore, Cargo.toml, and the added line from .travis.yml?
I think the sources of a-chat can be just dumped into examples/a-chat/
and then Cargo figures out how to compile that example on its own? There
should be a way to achieve that...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#144?email_source=notifications&email_token=AANB3M3KLUDYOEQONQPB273QH7XMRA5CNFSM4ITUDURKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCDVC7WY#pullrequestreview-283783131>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AANB3M24ERD6KNNA7WFQ4NLQH7XMRANCNFSM4ITUDURA>
.
|
|
Perfect, thanks! Can you run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this, I propose archiving https://github.com/async-rs/a-chat/: it seems bad that folks need to send PR to to repositories.