Skip to content

Minor documentation fix for race and try_race #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Nov 7, 2019
Merged

Minor documentation fix for race and try_race #473

1 commit merged into from
Nov 7, 2019

Conversation

abhishekc-sharma
Copy link
Contributor

race was being referred to as a macro. Additionally is the comment

Note that this function consumes all futures passed, and once a future is
completed, all other futures are dropped.

required for a function since this fact is more clear from the signature of the function than for macros ?

ghost
ghost approved these changes Nov 7, 2019
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghost ghost merged commit eb1ef3f into async-rs:master Nov 7, 2019
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer
Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abhishekc-sharma