[Confluence] page_exists method without error log #949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
page_exists() updated to make its own request and handle the response to return a True or False rather than utilising "self.get_page_by_title(space, title)" which outputs messages to the log if it cannot find a page.
|
Relates to issue 547 |
Codecov Report
@@ Coverage Diff @@
## master #949 +/- ##
==========================================
- Coverage 36.50% 36.47% -0.04%
==========================================
Files 34 34
Lines 6527 6533 +6
Branches 1007 1010 +3
==========================================
Hits 2383 2383
- Misses 4037 4043 +6
Partials 107 107
Continue to review full report at Codecov.
|
gonchik
pushed a commit
that referenced
this pull request
Sep 3, 2022
page_exists() updated to make its own request and handle the response to return a True or False rather than utilising "self.get_page_by_title(space, title)" which outputs messages to the log if it cannot find a page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confluence.py change to page_exists() function. Function will now make its own request and handle the response to determine the True or False value rather than utilising "self.get_page_by_title(space, title)" which outputs errors to the log if it cannot find a page.