This repository was archived by the owner on Dec 15, 2022. It is now read-only.
globalThis, self, frames #681
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames "meta.delimiter.*.period.js" to "meta.delimiter.*.js" (Renames meta.delimiter.property.period.js And meta.delimiter.method.period.js) Match transforms many "\\." to "(\\.|\\?\\.)" (parenthesis sometimes used since it's unnecessary)
In keyword.operator.logical.js, because it's similar to the || operator.
|
Today I did |
Renames "meta.delimiter.*.period.js" to "meta.delimiter.*.js"
Only 1 change. I can't believe it. Sigh. See #1: atom@a527d0d appveyor is amazing!!! =O
|
I'm making a new pull request with a branch - see previous comment |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Adds:
self === window, andframes === windowAlso, globalThis was added to js. It's a way to reference the value of (this) in any global scope.
MDN links:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/globalThis
https://developer.mozilla.org/en-US/docs/Web/API/Window/window
https://developer.mozilla.org/en-US/docs/Web/API/Window/self
https://developer.mozilla.org/en-US/docs/Web/API/Window/frames
Currently only updates tree-sitter-javascript.cson, and not javascript.cson
Benefits
This is only a minor update
Possible Drawbacks
globalThis doesn't always point to a DOM object, so it's only in support.variable
In a worker context, self resolves to
WorkerGlobalScope.selfinstead ofwindow.self, so maybe also put that in support.variable