Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

GitHub Actions #684

Merged
merged 1 commit into from
Dec 11, 2020
Merged

GitHub Actions #684

merged 1 commit into from
Dec 11, 2020

Conversation

aminya
Copy link
Contributor

@aminya aminya commented Nov 12, 2020

Description of the change

Use GitHub Actions instead of Travis and Appveyor.

Benefits

  • GitHub Actions is much faster than the other CI services and allows parallel runs
  • GitHub Actions it is much easier to configure.
  • Atom is a GitHub product, so we should use GitHub Actions.
  • Travis is making its services limited and monetary.
    https://blog.travis-ci.com/2020-11-02-travis-ci-new-billing

Verification

The CI passes: https://github.com/aminya/language-javascript/actions/runs/359738214

Drawbacks

none

Release Notes

N/A

@icecream17
Copy link
Contributor

(Probably a silly question)
Is AppVeyor removed because it's redundant?

@aminya
Copy link
Contributor Author

aminya commented Nov 12, 2020

Appveyor was being used for testing the code on Windows. But now GitHub Actions has Windows support, we don't need Appveyor anymore.

P.S: Because I don't have access to this organization, I cannot set the "ignore build if no appveyor.yml" option, which disables Appveyor when appveyor.yml is deleted. So I have to use a dummy appveyor.yml to achieve the same thing.

@icecream17 icecream17 mentioned this pull request Nov 21, 2020
@darangi darangi merged commit a5f8406 into atom:master Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants