This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Use new TSX-aware TreeSitter grammar #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit was tested by linking locally and does not yet include the dependency upgrade in package.json. Co-Authored-By: Antonio Scandurra <[email protected]>
This was referenced May 23, 2019
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍐'd with @as-cii
This PR updates our TreeSitter grammar dependency to use a separate grammar for TSX that supports type arguments in JSX expressions. See tree-sitter/tree-sitter-typescript#68 for more details on the change. We need to wait for that PR to land so we can publish a new version and update our dependency in this module. These changes were tested by linking locally.
Fixes #34
Closes #33
Fixes atom/ide-typescript#145