Add unit test to GH #1 #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If /dev/tty is inaccessible, redirecting file handles to STDERR:
open (my $fh, ">&STDERR))
... cannot be done as a 3 arg open or it'll actually try to write to that
file.
Bump $Term::ReadLine::VERSION.
For: RT #132008
Term::ReadLine generates empty &STDERR files GH #1
atoomic
pushed a commit
that referenced
this pull request
Jul 30, 2020
This requires a few small changes. 1. add a new option, which I stored in what looked like one of the standard ways 2. only store the item in terminal history if >= this length 3. only add to @hist if >= this length 4. only display hist item if >= this length I believe #4 is redundant and should be removed, but the code was already effectively there.
atoomic
pushed a commit
that referenced
this pull request
Sep 24, 2020
[DELTA] 1.854 16 September 2020 * Prefer direct notation over indirect (#4) * Make hint/BS snippets strict compliant. * trim whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You would find attached to this message the extra unit test (as patch #1) to show the failure before/after the fix from James.
Note that the unit test required some minor refactor of Term::ReadLine to mock /dev/tty.
I've pushed to my github branch the test + James commit on top of it to fix the issue,
unfortunately I've not tested this on windows, so test are disabled for now on windows
as the behavior is different.
Perl/perl5@99333cd...atoomic:devel/rt-132008
Note: looks like the upstream git repo from the cpan distribution points to https://github.com/rafl/term-readline which is outdated, not sure if there is a more recent git repo for upstream where we can submit these changes, and update the META informations