Adding support for DI/1

[marbetschar]

As I've seen this is planned already, I would suggest to add support for DI/1 right now. We are using the IoC framework already in our production sites.

I know it's currently not stable, but it works really good for now.

Here's what I've added in our Application.cfc to adding support for DI/1 in Taffy:

<cffunction name="getBeanListFromExternalFactory" output="false" access="private" returntype="string">
    <cfset local.beanFactory = application._taffy.externalBeanFactory />
    <cfset local.beanInfo = local.beanFactory.getBeanInfo().beanInfo />
    <cfset local.beanList = '' />

    <cfloop collection="#local.beanInfo#" item="local.beanName">
        <cfif structKeyExists(local.beanInfo[local.beanName],'name') AND local.beanName NEQ local.beanInfo[local.beanName].name AND isInstanceOf(local.beanFactory.getBean(local.beanName),'taffy.core.resource')>
            <cfset local.beanList = listAppend(local.beanList,local.beanName) />
        </cfif>
    </cfloop>

    <cfreturn local.beanList />
</cffunction>

[atuttle]

I've got this mostly implemented (with some modifications). Just one question: What is the purpose of this comparison in your IF statement inside the loop?

local.beanName NEQ local.beanInfo[local.beanName].name

[marbetschar]

Good question, can't remember why I've added this. Maybe because I've put all Collections / Members into subdirectories and therefore they can't be named just "bean" in my case, the have to be named "beanMember" or "beanCollection".

Seems not to be necessery in a generic implementation from my point of view.

[atuttle]

OK.

[atuttle]

After removing it, I see that DI/1 includes the bean information twice (once under the CFC name, another time with the alias). That line actually prevents it from giving the same instance to Taffy twice, so it's needed. :)

[marbetschar]

Ok - Now as you are mentioning I remember this behaviour of DI/1 :)

Am 02.01.2013 um 14:45 schrieb Adam Tuttle notifications@github.com:

After removing it, I see that DI/1 includes the bean information twice (once under the CFC name, another time with the alias). That line actually prevents it from giving the same instance to Taffy twice, so it's needed. :)

—
Reply to this email directly or view it on GitHub.