Regex does not allow using similar endpoints with and without variable

[marbetschar]

The problem I'm facing right now is the following:

I've got the following REST endpoints:
/users/{userId}
/users/profile
/users/logout

As in the /users/{branchId} the second part is defined as variable, the /users/profile and the /users/logout wont work. I think this is not the expected behaviour, since these endpoints are explicity defined. For sure, there can't be a user with an id of "profile" or "logout" - but I think this is a design decision which is up to the one who is developing the REST API itself.

[atuttle]

Hmmm, definitely an interesting problem. The issue is that we take {userId} and convert it to ([^/]+), so "profile" and "logout" both match that. As a temporary fix you could use a custom regex that excludes those values; for example, if userId is numeric: {userId:\d+}

But definitely something we need to think about!

[atuttle]

Another solution I would consider in the meantime would be using this format:

/users/{userid}
/users/{userid}/profile
/logout

[atuttle]

Resolution to this issue will be to:

1. Not throw an exception when a static string is similar to one with tokens
2. Sort the list of URIs and make sure static values come before token regexes
3. Make the URI matcher use the sorted list of URI regexes.

This is something that we should probably have in the next version, so I've assigned it to that milestone. Still need to figure out if the next version will be 1.3 or 2.0 -- depends on the included features.

[atuttle]

New section URI Matching Order added to: https://github.com/atuttle/Taffy/wiki/Configuration-via-Metadata