dashboard cleanup #394
dashboard cleanup #394
Conversation
scrittler
commented
Mar 26, 2020
scrittler
commented
- move URI to left column for easier visual identification
- move cfc name to content panel
- ensure URI sorting is case-insensitive
* move URI to left column for easier visual identification * move cfc name to content panel * ensure URI sorting is case-insensitive
| @@ -852,7 +852,7 @@ | |||
| <cffunction name="sortURIMatchOrder" access="private" output="false"> | |||
| <cfargument name="endpoints" /> | |||
| <cfset var URIMatchOrder = listToArray( structKeyList(arguments.endpoints, chr(10)), chr(10) ) /> | |||
| <cfset arraySort(URIMatchOrder, "text", "desc") /> | |||
| <cfset arraySort(URIMatchOrder, "textnocase", "desc") /> | |||
There was a problem hiding this comment.
This line change gave me quite a bit of pause. I was worried that we might lose some nuance of the way we handle incoming URI's and some tiny corner case bug might be introduced by moving from more explicit to less...
But then I realized that we're using these strings as patterns in a reMatchNoCase() so it was already case insensitive.
Line 864 in a24e0f8
I am still mildly curious what problem this solves. The only thing I can think of is carelessness from developers in using consistent casing that might result in separation of resources in the dashboard that might have otherwise been grouped:
For example, using a case-sensitive sort:
/Users/abb
/users/bbb
/users/aaa
Whereas a case-insensitive sort would result in:
/users/bbb
/Users/abb
/users/aaa
