-
Notifications
You must be signed in to change notification settings - Fork 117
ColdSpring AOP Bean Support #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…tatement checks the component meta data for a new taffy namespace convention - taffy:aopbean. If that convention is present is uses this to override the default Taffy behavior when setting the beanName into cache, thus allowing all of Taffy's existing code to run as is, but allowing ColdSpring AOP to work.
Looks interesting. Can you amend this with a new example in the /examples folder that illustrates how it works? It would be pretty awesome if you could also include a test or two around the functionality, but it's not required. :) |
…affy / taffy:aopbean. One example demonstrates wrapping caching around a resource, the second demonstrates how a developer could add a system-wide return format without having to add the code to each resource cfc. There was one issue getting the formatting example to work, which was that I had to flip the access mode of representationOf() to public. If we can find a way around that, I'm happy to revert it back to private. Additionally, a change was made to core/api.cfc in the reload logic. Because in all likelihood ColdSpring will be instantiated as application scope singleton, reload() as existed would not update changes to the ColdSpring config file. Now, it also re-fires applicationStartEvent() so it actually resets ColdSpring (and user's custom application start events) as well.
Added a couple examples. Would be happy to write a readme for them if necessary. Would be happy to write tests, but shamefully, I'm not well-versed in it at this time. |
Planning to review this in a week or so. Just too busy right now. :) |
Thinking of targeting this for 1.1+1 (whether that's 1.2 or 2.0) |
Right on. Its purpose make sense now? On Fri, Aug 19, 2011 at 3:26 PM, atuttle <
|
Hey, Adam. That all makes sense to me. Thanks for pointing that out. I will add support for the underscores as well. |
Manually merged into 1.1-rc branch to be included in 1.1. Thanks for all of your effort! |
Happy to help. Hope others find it useful. If you need help with the docs On Sun, Nov 6, 2011 at 1:07 AM, Adam Tuttle <
|
I will probably ping you once I've got the format for the updated docs nailed down. Having you document it would be best, I think. :) |
Added conditional statement to the cacheBeanMetaData() method. This statement checks the component meta data for a new taffy namespace convention - taffy:aopbean. If that convention is present is uses this to override the default Taffy behavior when setting the beanName into cache, thus allowing all of Taffy's existing code to run as is, but allowing ColdSpring AOP to function.