Skip to content

Bugfix for queryString issue #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2011
Merged

Bugfix for queryString issue #49

merged 2 commits into from
Sep 29, 2011

Conversation

gregmoser
Copy link
Contributor

If a request is made using "get" and a key value pair in the queryString has no value, then taffy was setting the value as the key before. For example:

http://www.myAPI.com/index.cfm/myResource/?keyOne=valueOne&keyTwo=&keyThree=valueThree

taffy was passing into the arguments keyTwo = keyTwo because listLast() and listFirst() was the same... however this pull request should fix that.

-Greg

@gregmoser
Copy link
Contributor Author

So I added the test case, but to be honest I haven't speant a ton of time with MXUnit (but i plan too). Anyway, every attempt I made to execute the test failed because application was undefined, but I also noticed that your other tests fail with the same error. Is there a trick to executing these test cases?

@atuttle
Copy link
Owner

atuttle commented Aug 17, 2011

For some reason running the tests doesn't seem to instantiate the application. I always just hit http://localhost/taffy/tests/?dashboard once in my browser before I start working on things, and that does the trick.

I'm also going to be adding a web-runner so you don't have to use the Eclipse plugin to run the tests (or did I do that already?)...

At any rate, thanks for taking a stab at it. I'll grab your stuff and see if I can get it running... at some point. :)

atuttle pushed a commit that referenced this pull request Sep 29, 2011
Bugfix for queryString issue
@atuttle atuttle merged commit e36e5e7 into atuttle:1.1-rc Sep 29, 2011
boblee12 pushed a commit to wolfnet/Taffy that referenced this pull request Nov 9, 2012
Bugfix for queryString issue

git-svn-id: https://github.com/wolfnet/Taffy.git/trunk@282 a9f385df-67b6-ee62-c877-ce57b7db7bff
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants