Performance regression on crypto `createPublicKey` and `createPrivateKey` APIs after node v17

[canova]

Hi, we use this package for our profiler-server repository. After upgrading the node version from v16 to v18, we observed ~30% performance regression. And after some investigation we realized that it's because of the createPublicKey and createPrivateKey calls that happen here:

node-jsonwebtoken/verify.js

Lines 122 to 125 in bc28861

	secretOrPublicKey = createPublicKey(secretOrPublicKey);
	} catch (_) {
	try {
	secretOrPublicKey = createSecretKey(typeof secretOrPublicKey === 'string' ? Buffer.from(secretOrPublicKey) : secretOrPublicKey);

I also filed an issue on nodejs for the regression on those APIs. For more context, please see it here: nodejs/node#50386

I was wondering if we can reduce the calls to these APIs in this repository with some caching mechanism maybe? I'm not sure as I'm not familiar with the code here. Wanted to ask to see if you have any ideas, thanks!

Version of this library used: 9.0.2

[julienw]

Please unsubscribe me. Thx. Am Mi., 25. Okt. 2023 um 14:40 Uhr schrieb Nazım Can Altınova < @.>:
…
Hi, we use this package for our profiler-server https://github.com/firefox-devtools/profiler-server repository. After upgrading the node version from v16 to v18, we observed ~30% performance regression. And after some investigation we realized that it's because of the createPublicKey and createPrivateKey calls that happen here:

node-jsonwebtoken/verify.js

Lines 122 to 125 in bc28861

	secretOrPublicKey = createPublicKey(secretOrPublicKey);
	} catch (_) {
	try {
	secretOrPublicKey = createSecretKey(typeof secretOrPublicKey === 'string' ? Buffer.from(secretOrPublicKey) : secretOrPublicKey);

I also filed an issue on nodejs for the regression on those APIs. For more context, please see it here: nodejs/node#50386 <nodejs/node#50386> I was wondering if we can reduce the calls to these APIs in this repository with some caching mechanism maybe? I'm not sure as I'm not familiar with the code here. Wanted to ask to see if you have any ideas, thanks! Version of this library used: 9.0.2 — Reply to this email directly, view it on GitHub <#944>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUZJMY6B5EQUTUBVCBWRKUDYBECE5AVCNFSM6AAAAAA6PJ5Q3OVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3DCMZSHEZTKOA . You are receiving this because you are subscribed to this thread.Message ID: @.>

Please click on the link at the end of your mail