This repository was archived by the owner on Jun 10, 2022. It is now read-only.
Add picture to UserProfile
#14
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,6 +41,7 @@ | |||
| private static final String NAME_KEY = "name"; | |||
| private static final String NICKNAME_KEY = "nickname"; | |||
| private static final String CREATED_AT_KEY = "createdAt"; | |||
| private static final String PICTURE = "picture"; | |||
There was a problem hiding this comment.
For consistency let's call it PICTURE_KEY
|
Don't forget to update the very simple test at |
update UserProfileBridgeTest for picture (+2 squashed commits) Squashed commits: [a218e35] rename PICTURE_KEY [9660c9c] Add `picture` to UserProfile
wayneholis
force-pushed
the
hotfix-profile-picture
branch
from
9660c9c to
cc57cbe
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference from User Profile doc
Currently UserProfile do not returned with
picture.