Skip to content

start updating scikit-learn #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

start updating scikit-learn #1372

wants to merge 1 commit into from

Conversation

auvipy
Copy link

@auvipy auvipy commented Jan 18, 2022

to address #1371

@codecov
Copy link

codecov bot commented Jan 18, 2022

Codecov Report

Merging #1372 (9b63c6f) into master (cd4fef9) will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1372      +/-   ##
==========================================
- Coverage   88.13%   87.99%   -0.15%     
==========================================
  Files         140      140              
  Lines       11163    11163              
==========================================
- Hits         9839     9823      -16     
- Misses       1324     1340      +16     
Impacted Files Coverage Δ
.../components/feature_preprocessing/kitchen_sinks.py 83.33% <0.00%> (-13.34%) ⬇️
...mponents/feature_preprocessing/nystroem_sampler.py 85.29% <0.00%> (-5.89%) ⬇️
...ine/components/feature_preprocessing/kernel_pca.py 94.73% <0.00%> (-1.76%) ⬇️
autosklearn/util/logging_.py 88.96% <0.00%> (-1.38%) ⬇️
...learn/pipeline/components/regression/libsvm_svr.py 90.24% <0.00%> (-1.22%) ⬇️
autosklearn/pipeline/components/regression/sgd.py 95.78% <0.00%> (-1.06%) ⬇️
...ine/components/classification/gradient_boosting.py 93.04% <0.00%> (-0.87%) ⬇️
autosklearn/evaluation/abstract_evaluator.py 92.27% <0.00%> (-0.78%) ⬇️
autosklearn/automl.py 86.97% <0.00%> (-0.13%) ⬇️
...n/pipeline/components/classification/libsvm_svc.py 89.28% <0.00%> (+1.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd4fef9...9b63c6f. Read the comment docs.

@auvipy
Copy link
Author

auvipy commented Jan 18, 2022

I will check the codes & try to make them pass gradually

@eddiebergman
Copy link
Contributor

That's fine, I just enabled checks so they can run regularly, no rush :)

@eddiebergman
Copy link
Contributor

Hi @auvipy,

Do you plan to continue this? If not, I would rather close this and deal with it when we're ready.

Best,
Eddie

@auvipy
Copy link
Author

auvipy commented Feb 3, 2022

I will start working on this from next monday :D just ping me that day

@eddiebergman
Copy link
Contributor

No problem, just checking that there's still a future plan to work on this :)

@github-actions github-actions bot added the Stale label Jun 15, 2022
@github-actions github-actions bot closed this Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants