-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Fix timeouts related to metalearnings tests #1508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix timeouts related to metalearnings tests #1508
Conversation
Codecov Report
@@ Coverage Diff @@
## development #1508 +/- ##
===============================================
+ Coverage 83.77% 83.83% +0.06%
===============================================
Files 152 153 +1
Lines 11667 11694 +27
Branches 2037 2047 +10
===============================================
+ Hits 9774 9804 +30
+ Misses 1344 1339 -5
- Partials 549 551 +2 |
I switched to using I'm going to run the actions a few time and see if it comes up again. |
All the timeouts that occur seem to have moved to the next script where there was a hardcoded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Does it solve all issues?
I just set explicit timeouts for each step and bumped the overall timeout per test from |
I removed the comment you left review on, if all the tests pass then I think that can be merged |
* Add debug statements and 30s timeouts * Fix formatting * Update internal timeout param * +timeout, use allocated tmpdir * +timeout, use allocated tmpdir * Remove another occurence of explicit `tmp` * Increase timelimits once again * Remove incomplete comment
Adding debug statements for now to find the problem on the github action servers as it cleanly finished locally.
Closes #1506