-
-
Notifications
You must be signed in to change notification settings - Fork 247
Finish part of Chinese translation for Pydoll #176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
LunacyZeus
wants to merge
14
commits into
autoscrape-labs:main
Choose a base branch
from
LunacyZeus:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Thanks @LunacyZeus , I'll take a look tomorrow :) |
Hi @LunacyZeus , sorry for the delay. I'm working on a few changes on the README and the documentation in general to make it more clear. I hope that is not a problem but you'll have to translate some parts again :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
sorry i opened PR in the wrong branch, now it fixed! I have completed the Chinese translation of most of the documents except the deep-dive directory. All Chinese content has been proofread and is now more in line with Chinese linguistic conventions. I will finish the translation of deep-dive in the next few days. BTW, there is a problem, I can't make mkdocs support both Chinese and English, which will destroy the existing document structure. This may require your help. If you have any problem pls contact me! Finally, when I finish the translation of deep-dive, I will write more about Pydoll's usage tips for web crawlers in Chinese combined with actual projects.
Yours sincerely~
Related Issue(s)
Resolves #155
Type of Change
How Has This Been Tested?
# Include code examples if relevant
Testing Checklist
Screenshots
Implementation Details
API Changes
Additional Info
Checklist before requesting a review
poetry run task lint
and fixed any issuespoetry run task test
and all tests pass