Skip to content

Finish part of Chinese translation for Pydoll #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

LunacyZeus
Copy link

Pull Request

Description

sorry i opened PR in the wrong branch, now it fixed! I have completed the Chinese translation of most of the documents except the deep-dive directory. All Chinese content has been proofread and is now more in line with Chinese linguistic conventions. I will finish the translation of deep-dive in the next few days. BTW, there is a problem, I can't make mkdocs support both Chinese and English, which will destroy the existing document structure. This may require your help. If you have any problem pls contact me! Finally, when I finish the translation of deep-dive, I will write more about Pydoll's usage tips for web crawlers in Chinese combined with actual projects.
Yours sincerely~

Related Issue(s)

Resolves #155

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring (no functional changes, no API changes)
  • Performance improvement
  • Tests (adding missing tests or correcting existing tests)
  • Build or CI/CD related changes

How Has This Been Tested?

# Include code examples if relevant

Testing Checklist

  • Unit tests added/updated
  • Integration tests added/updated
  • All existing tests pass

Screenshots

Implementation Details

API Changes

Additional Info

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run poetry run task lint and fixed any issues
  • I have run poetry run task test and all tests pass
  • My commits follow the conventional commits style

Copy link

codecov bot commented Jun 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@thalissonvs
Copy link
Member

Thanks @LunacyZeus , I'll take a look tomorrow :)

@thalissonvs
Copy link
Member

Hi @LunacyZeus , sorry for the delay. I'm working on a few changes on the README and the documentation in general to make it more clear. I hope that is not a problem but you'll have to translate some parts again :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Chinese Documentation Support Plan
2 participants